Port update-catalog validation+PR flow from main to v5#134
Open
bhillkeyfactor wants to merge 3 commits into
Open
Port update-catalog validation+PR flow from main to v5#134bhillkeyfactor wants to merge 3 commits into
bhillkeyfactor wants to merge 3 commits into
Conversation
The same change that landed on main as part of replacing the direct- to-main commit pattern with a validating, PR-based flow. Every integration repo's caller workflow pins to @v5 (see starter.yml line 141), so the main-branch merge didn't actually reach any caller — v5 still ran the old add-and-commit direct push. This is why entries like godaddy-dnsplugin (commit fb2f11b on the catalog repo) continued to land on integrations-catalog main with no PR after the main merge. Bringing the v5 branch up to parity ensures the next integration push routes through the validation gate and opens a labeled PR against integrations-catalog instead of force-committing to main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
spbsoluble
approved these changes
May 15, 2026
…pdate-catalog-to-v5`
d54dcab to
e86ab22
Compare
1. link_github default — jq's // operator treats both null AND false
as "use the default", so `.link_github // "true"` silently flipped
`link_github: false` manifests to "true". On a private repo (like
the godaddy-dnsplugin test) that's the exact path that gets
rejected as a broken-link case. Switch to an explicit null check
so a literal `false` is preserved.
2. -dev failsafe grep — pattern '-(dev|test|staging|poc)$' starts
with a dash, so grep interpreted it as a flag and emitted
"invalid option -- '('". Execution continues (the if-condition
just evaluates false) but the failsafe wasn't actually firing —
any -dev / -test / -staging / -poc repo would slip past this
check. Add a -- separator so grep treats the next arg as the
pattern.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same change that landed on main as part of replacing the direct- to-main commit pattern with a validating, PR-based flow. Every integration repo's caller workflow pins to @v5 (see starter.yml line 141), so the main-branch merge didn't actually reach any caller — v5 still ran the old add-and-commit direct push. This is why entries like godaddy-dnsplugin (commit fb2f11b on the catalog repo) continued to land on integrations-catalog main with no PR after the main merge.
Bringing the v5 branch up to parity ensures the next integration push routes through the validation gate and opens a labeled PR against integrations-catalog instead of force-committing to main.